Google Critique code review tool

As heralded by several Hacker News readers (story title: Google takes the pain out of code review, with 97% dev satisfaction) as the one tool they really miss.


linkWhy "97% of developers love it"

The research Google released claims that 97% of their devs love it:

Static analysis included

Focus on only the latest changed files (seemingly in contrast to showing previously reviewed changes?). A familiar, side-by-side diffing interface: It shows "diff from the last review" by default.

"Action set tracking" so it's always apparent whose move is next

"Satisfying gamification: While Critique isn’t built to be gamified, Googlers reported how they enjoyed it when Critique “went green,” which meant a PR was ready to submit (all tests passed, reviewers LGTM-ed and approved". Weird.

It shows my "Diff since last review" as default

It is better at detecting noops than other tools (heya 👋 )

Its always apparent whose move is next

Companion Chrome extension does notifications & review queue

"Reviewers link to documents and styleguides all the time". Seems like a good PR v2 objective?

Static analysis tool could help discover where missing test coverage existed


linkStatic analysis

One of the most cited benefits is Critique's static analysis. Here are details aplenty on how that works.


linkScreenshots and element analysis


Busy!

"Score" is an interesting name for a field. Seems like a field for acquiring permissions?

"Bugs" is another Interesting field name. Perhaps that is where you specify the Jira (-equivalent) ticket the "CL" addresses?

The "Grab snapshot" button is an intriguing possibility

Cute: they have their own "Delta" field for files, presumably the number of changed lines?

The "Analysis" column seems to imply that there are jobs that get run on PRs, in this case Presubmit: CheckProtoSyntax, which is mentioning "Your change contains one or more new .proto files without a syntax statement. Each .proto file must have a syntax statement in order to submit."



Pretty much us, except without advanced ops (in any obvious way), means to comment on a file, and separate button to "Show ML-edit". That seems like a good option when combining a comment with a line. Added to Pull Request Dev Todo



Delightfully concise

Smart idea to classify size in XS/S/M/L/XL


linkAlso